src/com/wjholden/nmap/Nmap.java:1 A high number of imports can indicate a high degree of coupling within an object. src/com/wjholden/nmap/Nmap.java:47 The class 'Nmap' has a Cyclomatic Complexity of 7 (Highest = 45). src/com/wjholden/nmap/Nmap.java:47 This class has too many methods, consider refactoring it. src/com/wjholden/nmap/Nmap.java:47 Too many fields src/com/wjholden/nmap/Nmap.java:51 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/Nmap.java:56 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/Nmap.java:61 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/Nmap.java:66 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/Nmap.java:71 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/Nmap.java:71 Perhaps 'mHelp' could be replaced by a local variable. src/com/wjholden/nmap/Nmap.java:76 Perhaps 'mShare' could be replaced by a local variable. src/com/wjholden/nmap/Nmap.java:94 Avoid excessively long variable names like installationVerified src/com/wjholden/nmap/Nmap.java:114 Avoid variables with short names like sh src/com/wjholden/nmap/Nmap.java:140 Avoid variables with short names like h src/com/wjholden/nmap/Nmap.java:147 Avoid variables with short names like pd src/com/wjholden/nmap/Nmap.java:157 Perhaps 'preferencesEditor' could be replaced by a local variable. src/com/wjholden/nmap/Nmap.java:165 The field name indicates a constant but its modifiers do not src/com/wjholden/nmap/Nmap.java:165 Variables should start with a lowercase character src/com/wjholden/nmap/Nmap.java:171 Avoid variables with short names like ne src/com/wjholden/nmap/Nmap.java:176 Perhaps 'wifiManager' could be replaced by a local variable. src/com/wjholden/nmap/Nmap.java:181 Perhaps 'wifiInfo' could be replaced by a local variable. src/com/wjholden/nmap/Nmap.java:184 Avoid excessively long variable names like savedInstanceState src/com/wjholden/nmap/Nmap.java:184 Avoid really long methods. src/com/wjholden/nmap/Nmap.java:184 Parameter 'savedInstanceState' is not assigned and could be declared final src/com/wjholden/nmap/Nmap.java:184 The method 'onCreate' has a Cyclomatic Complexity of 45. src/com/wjholden/nmap/Nmap.java:184 The method onCreate() has an NPath complexity of 826200 src/com/wjholden/nmap/Nmap.java:198 Local variable 'adapterCommand' could be declared final src/com/wjholden/nmap/Nmap.java:206 Parameter 'arg0' is not assigned and could be declared final src/com/wjholden/nmap/Nmap.java:206 Parameter 'arg1' is not assigned and could be declared final src/com/wjholden/nmap/Nmap.java:207 Parameter 'arg2' is not assigned and could be declared final src/com/wjholden/nmap/Nmap.java:207 Parameter 'arg3' is not assigned and could be declared final src/com/wjholden/nmap/Nmap.java:222 Local variable 'adapterOutput' could be declared final src/com/wjholden/nmap/Nmap.java:246 Local variable 'target' could be declared final src/com/wjholden/nmap/Nmap.java:250 Local variable 'args' could be declared final src/com/wjholden/nmap/Nmap.java:255 Local variable 'result' could be declared final src/com/wjholden/nmap/Nmap.java:258 The String literal "installationVerified" appears 4 times in this file; the first occurrence is on line 258 src/com/wjholden/nmap/Nmap.java:260 The String literal "hasRunOneScan" appears 4 times in this file; the first occurrence is on line 260 src/com/wjholden/nmap/Nmap.java:262 The String literal "canGetRoot" appears 4 times in this file; the first occurrence is on line 262 src/com/wjholden/nmap/Nmap.java:301 Avoid variables with short names like ip src/com/wjholden/nmap/Nmap.java:302 Avoid using if statements without curly braces src/com/wjholden/nmap/Nmap.java:311 The method 'handleMessage' has a Cyclomatic Complexity of 15. src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:313 Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). src/com/wjholden/nmap/Nmap.java:319 An empty statement (semicolon) not part of a loop src/com/wjholden/nmap/Nmap.java:321 Avoid if (x != y) ..; else ..; src/com/wjholden/nmap/Nmap.java:322 Avoid using if...else statements without curly braces src/com/wjholden/nmap/Nmap.java:324 Avoid using if...else statements without curly braces src/com/wjholden/nmap/Nmap.java:347 Position literals first in String comparisons src/com/wjholden/nmap/Nmap.java:348 Avoid using if...else statements without curly braces src/com/wjholden/nmap/Nmap.java:349 Position literals first in String comparisons src/com/wjholden/nmap/Nmap.java:350 Avoid using if...else statements without curly braces src/com/wjholden/nmap/Nmap.java:351 Position literals first in String comparisons src/com/wjholden/nmap/Nmap.java:352 Avoid using if...else statements without curly braces src/com/wjholden/nmap/Nmap.java:360 Avoid assignments in operands src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:360 Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). src/com/wjholden/nmap/Nmap.java:424 Avoid using if statements without curly braces src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:425 Found 'DU'-anomaly for variable 's' (lines '425'-'484'). src/com/wjholden/nmap/Nmap.java:488 Avoid instantiating String objects; this is usually unnecessary. src/com/wjholden/nmap/Nmap.java:493 Avoid instantiating String objects; this is usually unnecessary. src/com/wjholden/nmap/Nmap.java:498 Avoid using if statements without curly braces src/com/wjholden/nmap/Nmap.java:500 Avoid using if statements without curly braces src/com/wjholden/nmap/Nmap.java:506 Avoid excessively long variable names like savedInstanceState src/com/wjholden/nmap/Nmap.java:514 Avoid using if statements without curly braces src/com/wjholden/nmap/Nmap.java:578 Use bitwise inversion to invert boolean values src/com/wjholden/nmap/NmapError.java:21 Avoid using implementation types like 'ArrayList'; use the interface instead src/com/wjholden/nmap/NmapError.java:21 Avoid using implementation types like 'ArrayList'; use the interface instead src/com/wjholden/nmap/NmapError.java:21 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/NmapError.java:21 Private field 'errors' could be made final; it is only initialized in the declaration or constructor. src/com/wjholden/nmap/NmapError.java:33 Avoid variables with short names like s src/com/wjholden/nmap/NmapError.java:33 Method names should not start with capital letters src/com/wjholden/nmap/NmapError.java:33 Parameter 's' is not assigned and could be declared final src/com/wjholden/nmap/NmapError.java:42 Avoid using if statements without curly braces src/com/wjholden/nmap/NmapError.java:50 Method names should not start with capital letters src/com/wjholden/nmap/NmapError.java:52 Avoid variables with short names like s src/com/wjholden/nmap/NmapError.java:53 Local variable 'stop' could be declared final src/com/wjholden/nmap/NmapError.java:56 Prefer StringBuffer over += for concatenating strings src/com/wjholden/nmap/NmapUtilities.java:18 All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. src/com/wjholden/nmap/NmapUtilities.java:27 Avoid variables with short names like c src/com/wjholden/nmap/NmapUtilities.java:27 Parameter 'c' is not assigned and could be declared final src/com/wjholden/nmap/NmapUtilities.java:29 Local variable 'tmpdir' could be declared final src/com/wjholden/nmap/NmapUtilities.java:46 Local variable 'msg' could be declared final src/com/wjholden/nmap/NmapUtilities.java:65 Local variable 'path' could be declared final src/com/wjholden/nmap/NmapUtilities.java:66 Avoid variables with short names like st src/com/wjholden/nmap/NmapUtilities.java:66 Local variable 'st' could be declared final src/com/wjholden/nmap/NmapUtilities.java:69 Local variable 'token' could be declared final src/com/wjholden/nmap/NmapUtilities.java:70 Avoid instantiating new objects inside loops src/com/wjholden/nmap/NmapUtilities.java:76 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/NmapUtilities.java:76 This statement may have some unnecessary parentheses src/com/wjholden/nmap/NmapUtilities.java:84 This statement may have some unnecessary parentheses src/com/wjholden/nmap/NmapUtilities.java:92 Avoid variables with short names like c src/com/wjholden/nmap/NmapUtilities.java:92 Parameter 'c' is not assigned and could be declared final src/com/wjholden/nmap/NmapUtilities.java:95 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/NmapUtilities.java:95 This statement may have some unnecessary parentheses src/com/wjholden/nmap/NmapUtilities.java:98 This statement may have some unnecessary parentheses src/com/wjholden/nmap/NmapUtilities.java:109 Parameter 'myDataDir' is not assigned and could be declared final src/com/wjholden/nmap/NmapUtilities.java:119 This statement may have some unnecessary parentheses src/com/wjholden/nmap/Nmap_Constants.java:12 An Interface should be used only to model a behaviour; consider converting this to a class. src/com/wjholden/nmap/Nmap_Constants.java:16 Avoid modifiers which are implied by the context src/com/wjholden/nmap/Nmap_Constants.java:21 Avoid modifiers which are implied by the context src/com/wjholden/nmap/Nmap_Constants.java:26 Avoid modifiers which are implied by the context src/com/wjholden/nmap/Nmap_Constants.java:31 Avoid modifiers which are implied by the context src/com/wjholden/nmap/Nmap_Constants.java:36 Avoid modifiers which are implied by the context src/com/wjholden/nmap/Nmap_Constants.java:55 Avoid excessively long variable names like MENU_ITEM_DEBUG_ENABLE src/com/wjholden/nmap/Nmap_Constants.java:56 Avoid excessively long variable names like MENU_ITEM_DEBUG_EMAIL src/com/wjholden/nmap/Nmap_Constants.java:57 Avoid excessively long variable names like MENU_ITEM_MORE_HELP src/com/wjholden/nmap/Nmap_Constants.java:58 Avoid excessively long variable names like MENU_ITEM_REINSTALL src/com/wjholden/nmap/Nmap_Constants.java:62 Avoid excessively long variable names like MENU_GROUP_EXTRA_OPTIONS src/com/wjholden/nmap/scan.java:25 Class names should begin with an uppercase character src/com/wjholden/nmap/scan.java:25 The class 'scan' has a Cyclomatic Complexity of 10 (Highest = 20). src/com/wjholden/nmap/scan.java:27 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/scan.java:28 Avoid excessively long variable names like executionParameters src/com/wjholden/nmap/scan.java:28 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/scan.java:28 Perhaps 'executionParameters' could be replaced by a local variable. src/com/wjholden/nmap/scan.java:29 Avoid variables with short names like c src/com/wjholden/nmap/scan.java:29 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/scan.java:29 Perhaps 'c' could be replaced by a local variable. src/com/wjholden/nmap/scan.java:31 Avoid variables with short names like os src/com/wjholden/nmap/scan.java:31 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/scan.java:31 Perhaps 'os' could be replaced by a local variable. src/com/wjholden/nmap/scan.java:32 Avoid variables with short names like in src/com/wjholden/nmap/scan.java:32 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/scan.java:32 Perhaps 'in' could be replaced by a local variable. src/com/wjholden/nmap/scan.java:33 Perhaps 'err' could be replaced by a local variable. src/com/wjholden/nmap/scan.java:34 Avoid variables with short names like p src/com/wjholden/nmap/scan.java:38 Switch statements should have a default label src/com/wjholden/nmap/scan.java:41 Avoid instantiating String objects; this is usually unnecessary. src/com/wjholden/nmap/scan.java:68 Avoid variables with short names like v src/com/wjholden/nmap/scan.java:68 Parameter 'v' is not assigned and could be declared final src/com/wjholden/nmap/scan.java:78 Avoid really long methods. src/com/wjholden/nmap/scan.java:78 Parameter 'params' is not assigned and could be declared final src/com/wjholden/nmap/scan.java:78 The method 'doInBackground' has a Cyclomatic Complexity of 20. src/com/wjholden/nmap/scan.java:78 The method doInBackground() has an NPath complexity of 59904 src/com/wjholden/nmap/scan.java:82 Avoid using if statements without curly braces src/com/wjholden/nmap/scan.java:102 Local variable 'msg' could be declared final src/com/wjholden/nmap/scan.java:106 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/scan.java:106 This statement may have some unnecessary parentheses src/com/wjholden/nmap/scan.java:109 Avoid using if...else statements without curly braces src/com/wjholden/nmap/scan.java:113 Local variable 'msg' could be declared final src/com/wjholden/nmap/scan.java:117 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/scan.java:117 This statement may have some unnecessary parentheses src/com/wjholden/nmap/scan.java:124 Avoid using if statements without curly braces src/com/wjholden/nmap/scan.java:126 Avoid using if statements without curly braces src/com/wjholden/nmap/scan.java:128 Avoid using if statements without curly braces src/com/wjholden/nmap/scan.java:139 Position literals first in String comparisons src/com/wjholden/nmap/scan.java:140 Avoid using if...else statements without curly braces src/com/wjholden/nmap/scan.java:172 Avoid assignments in operands src/com/wjholden/nmap/scan.java:175 Prefer StringBuffer over += for concatenating strings src/com/wjholden/nmap/scan.java:179 Local variable 'msg1' could be declared final src/com/wjholden/nmap/scan.java:186 Local variable 'msg' could be declared final src/com/wjholden/nmap/scan.java:194 Avoid assignments in operands src/com/wjholden/nmap/scan.java:196 Local variable 'msg' could be declared final src/com/wjholden/nmap/scan.java:219 Avoid using if statements without curly braces src/com/wjholden/nmap/scan.java:219 Position literals first in String comparisons src/com/wjholden/nmap/scan.java:221 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:28 Class names should begin with an uppercase character src/com/wjholden/nmap/verifyInstallation.java:28 The class 'verifyInstallation' has a Cyclomatic Complexity of 8 (Highest = 20). src/com/wjholden/nmap/verifyInstallation.java:33 Avoid excessively long variable names like installationResults src/com/wjholden/nmap/verifyInstallation.java:33 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/verifyInstallation.java:38 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/verifyInstallation.java:38 Private field 'filenames' could be made final; it is only initialized in the declaration or constructor. src/com/wjholden/nmap/verifyInstallation.java:43 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/verifyInstallation.java:43 Private field 'requiredResources' could be made final; it is only initialized in the declaration or constructor. src/com/wjholden/nmap/verifyInstallation.java:48 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/verifyInstallation.java:50 Found non-transient, non-static member. Please mark as transient or provide accessors. src/com/wjholden/nmap/verifyInstallation.java:50 Perhaps 'resources' could be replaced by a local variable. src/com/wjholden/nmap/verifyInstallation.java:52 Avoid variables with short names like v src/com/wjholden/nmap/verifyInstallation.java:52 Parameter 'v' is not assigned and could be declared final src/com/wjholden/nmap/verifyInstallation.java:59 Avoid really long methods. src/com/wjholden/nmap/verifyInstallation.java:59 Parameter 'params' is not assigned and could be declared final src/com/wjholden/nmap/verifyInstallation.java:59 The method 'doInBackground' has a Cyclomatic Complexity of 20. src/com/wjholden/nmap/verifyInstallation.java:59 The method doInBackground() has an NCSS line count of 102 src/com/wjholden/nmap/verifyInstallation.java:59 The method doInBackground() has an NPath complexity of 43920 src/com/wjholden/nmap/verifyInstallation.java:61 Found 'DU'-anomaly for variable 'buf' (lines '61'-'244'). src/com/wjholden/nmap/verifyInstallation.java:61 Local variable 'buf' could be declared final src/com/wjholden/nmap/verifyInstallation.java:62 Avoid if (x != y) ..; else ..; src/com/wjholden/nmap/verifyInstallation.java:63 Avoid using if...else statements without curly braces src/com/wjholden/nmap/verifyInstallation.java:65 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/verifyInstallation.java:65 Avoid using if...else statements without curly braces src/com/wjholden/nmap/verifyInstallation.java:75 Local variable 'in_nmap_a' could be declared final src/com/wjholden/nmap/verifyInstallation.java:76 Local variable 'in_nmap_b' could be declared final src/com/wjholden/nmap/verifyInstallation.java:77 Local variable 'in_nmap_c' could be declared final src/com/wjholden/nmap/verifyInstallation.java:78 Local variable 'out_nmap' could be declared final src/com/wjholden/nmap/verifyInstallation.java:102 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/verifyInstallation.java:102 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:113 Avoid using while statements without curly braces src/com/wjholden/nmap/verifyInstallation.java:116 Avoid using while statements without curly braces src/com/wjholden/nmap/verifyInstallation.java:127 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/verifyInstallation.java:127 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:138 Avoid instantiating new objects inside loops src/com/wjholden/nmap/verifyInstallation.java:152 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/verifyInstallation.java:152 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:162 Avoid variables with short names like p src/com/wjholden/nmap/verifyInstallation.java:163 Avoid variables with short names like os src/com/wjholden/nmap/verifyInstallation.java:164 Avoid variables with short names like in src/com/wjholden/nmap/verifyInstallation.java:201 Avoid variables with short names like e src/com/wjholden/nmap/verifyInstallation.java:202 Avoid assignments in operands src/com/wjholden/nmap/verifyInstallation.java:206 Avoid assignments in operands src/com/wjholden/nmap/verifyInstallation.java:231 A method should have only one exit point, and that should be the last statement in the method src/com/wjholden/nmap/verifyInstallation.java:231 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:237 This statement may have some unnecessary parentheses src/com/wjholden/nmap/verifyInstallation.java:246 Parameter 'path' is not assigned and could be declared final